Skip to content

fix: emit rustfmt-compliant #![allow] header#13

Merged
jrandolf merged 2 commits intomainfrom
fix/release-fmt
Apr 19, 2026
Merged

fix: emit rustfmt-compliant #![allow] header#13
jrandolf merged 2 commits intomainfrom
fix/release-fmt

Conversation

@jrandolf
Copy link
Copy Markdown
Contributor

Summary

  • The single-line #![allow(dead_code, reason = "…")] attribute the generator emitted in v0.1.4/v0.1.5 exceeded rustfmt's 100-col default, so cargo fmt --check failed the release workflow and the v0.1.5 wasm asset was never uploaded. See the failed run: https://github.com/mathematic-inc/sqlc-gen-sqlx/actions/runs/24376376904
  • Pre-wrap the attribute across multiple lines at emit time so the output is idempotent under rustfmt.
  • Regenerate the committed example snapshots and expand the root sqlc.yaml so sqlc generate covers all four examples (previously only basic was wired up).

Test plan

  • cargo fmt --all --check clean
  • cargo clippy --workspace --all-targets -- -D warnings clean
  • cargo test --lib --bins passes
  • cargo build --target wasm32-wasip1 produces a valid plugin
  • sqlc generate with the rebuilt wasm regenerates every example cleanly (sqlc.yaml sha updated to match)

Once merged, release-please should open a 0.1.6 PR; merging that will re-trigger release.yml with the format check passing and publish the wasm.

🤖 Generated with Claude Code

The single-line `#![allow(dead_code, reason = "…")]` attribute
emitted in v0.1.4/v0.1.5 exceeded rustfmt's default 100-col
max_width, so `cargo fmt --check` in CI failed on every release
and the workflow never uploaded the wasm asset.

Pre-wrap the attribute across multiple lines at emit time so the
output is idempotent under rustfmt. Regenerate the committed
example snapshots and expand the root `sqlc.yaml` to cover all
four examples (previously only `basic` was wired up) so
`sqlc generate` at repo root keeps every snapshot in sync.
@jrandolf jrandolf merged commit 04acf9a into main Apr 19, 2026
2 checks passed
@jrandolf jrandolf deleted the fix/release-fmt branch April 19, 2026 12:28
jrandolf added a commit that referenced this pull request Apr 19, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.1.6](v0.1.5...v0.1.6)
(2026-04-19)


### Bug Fixes

* Emit rustfmt-compliant #![allow] header
([#13](#13))
([04acf9a](04acf9a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant